Skip to content

Commit

Permalink
clk: Combine DT binding doc for max77686 and max77802
Browse files Browse the repository at this point in the history
The clock IP used on the Maxim PMICs max77686 and max77802 are
same. The configuration of clock register is also same except
the number of clocks.

Define the common DT binding file for the clocks of Maxim PMICs
MAX77686 and MAX77802. For this, remove the separate DT binding
document file for maxim,max77802 and move all information to
maxim,max77686 DT binding document.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
CC: Javier Martinez Canillas <javier@dowhile0.org>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
  • Loading branch information
Laxman Dewangan authored and Stephen Boyd committed Aug 15, 2016
1 parent 8ad313f commit 24f668d
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 67 deletions.
82 changes: 59 additions & 23 deletions Documentation/devicetree/bindings/clock/maxim,max77686.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
Binding for Maxim MAX77686 32k clock generator block
Binding for Maxim MAX77686/MAX77802 32k clock generator block

This is a part of device tree bindings of MAX77686 multi-function device.
More information can be found in bindings/mfd/max77686.txt file.
This is a part of device tree bindings of MAX77686/MAX77802 multi-function
device. More information can be found in bindings/mfd/max77686.txt file for
MAX77686 and bindings/mfd/max77802.txt for MAX77802.

The MAX77686 contains three 32.768khz clock outputs that can be controlled
(gated/ungated) over I2C.

The MAX77802 contains two 32.768khz clock outputs that can be controlled
(gated/ungated) over I2C.

Following properties should be presend in main device node of the MFD chip.

Required properties:
Expand All @@ -17,30 +21,62 @@ Optional properties:

Each clock is assigned an identifier and client nodes can use this identifier
to specify the clock which they consume. Following indices are allowed:
- 0: 32khz_ap clock,
- 1: 32khz_cp clock,
- 2: 32khz_pmic clock.
- 0: 32khz_ap clock (max77686, max77802),
- 1: 32khz_cp clock (max77686, max77802),
- 2: 32khz_pmic clock (max77686).

Clocks are defined as preprocessor macros in dt-bindings/clock/maxim,max77686.h
header and can be used in device tree sources.
header for MAX77686 and dt-bindings/clock/maxim,max77802.h for MAX77802 and can
be used in device tree sources.

Example:

1. With MAX77686:

#include <dt-bindings/clock/maxim,max77686.h>
/* ... */

Node of the MFD chip
max77686: max77686@09 {
compatible = "maxim,max77686";
interrupt-parent = <&wakeup_eint>;
interrupts = <26 0>;
reg = <0x09>;
#clock-cells = <1>;

/* ... */
};

Clock consumer node

foo@0 {
compatible = "bar,foo";
/* ... */
clock-names = "my-clock";
clocks = <&max77686 MAX77686_CLK_PMIC>;
};

2. With MAX77802:

Example: Node of the MFD chip
#include <dt-bindings/clock/maxim,max77802.h>
/* ... */

max77686: max77686@09 {
compatible = "maxim,max77686";
interrupt-parent = <&wakeup_eint>;
interrupts = <26 0>;
reg = <0x09>;
#clock-cells = <1>;
Node of the MFD chip
max77802: max77802@09 {
compatible = "maxim,max77802";
interrupt-parent = <&wakeup_eint>;
interrupts = <26 0>;
reg = <0x09>;
#clock-cells = <1>;

/* ... */
};
/* ... */
};

Example: Clock consumer node
Clock consumer node

foo@0 {
compatible = "bar,foo";
/* ... */
clock-names = "my-clock";
clocks = <&max77686 MAX77686_CLK_PMIC>;
};
foo@0 {
compatible = "bar,foo";
/* ... */
clock-names = "my-clock";
clocks = <&max77802 MAX77802_CLK_32K_AP>;
};
44 changes: 0 additions & 44 deletions Documentation/devicetree/bindings/clock/maxim,max77802.txt

This file was deleted.

0 comments on commit 24f668d

Please sign in to comment.