Skip to content

Commit

Permalink
RDMA/hns: Remove redundant memcpy()
Browse files Browse the repository at this point in the history
srq_context is a local variables and is only used to get some fields from
buffer of mailbox. It's meaningless to copy mailbox's buffer's contents
back to it.

Link: https://lore.kernel.org/r/1588931159-56875-8-git-send-email-liweihang@huawei.com
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
  • Loading branch information
Weihang Li authored and Jason Gunthorpe committed May 19, 2020
1 parent 7b611d2 commit 252067e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/infiniband/hw/hns/hns_roce_hw_v2.c
Original file line number Diff line number Diff line change
Expand Up @@ -5047,8 +5047,6 @@ static int hns_roce_v2_query_srq(struct ib_srq *ibsrq, struct ib_srq_attr *attr)
attr->max_wr = srq->wqe_cnt - 1;
attr->max_sge = srq->max_gs;

memcpy(srq_context, mailbox->buf, sizeof(*srq_context));

out:
hns_roce_free_cmd_mailbox(hr_dev, mailbox);
return ret;
Expand Down

0 comments on commit 252067e

Please sign in to comment.