Skip to content

Commit

Permalink
selftests: mlxsw: qos_mc_aware: Specify arping timeout as an integer
Browse files Browse the repository at this point in the history
[ Upstream commit 46ca111 ]

Starting from iputils s20190709 (used in Fedora 31), arping does not
support timeout being specified as a decimal:

$ arping -c 1 -I swp1 -b 192.0.2.66 -q -w 0.1
arping: invalid argument: '0.1'

Previously, such timeouts were rounded to an integer.

Fix this by specifying the timeout as an integer.

Fixes: a5ee171 ("selftests: mlxsw: qos_mc_aware: Add a test for UC awareness")
Signed-off-by: Amit Cohen <amitc@mellanox.com>
Reviewed-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Amit Cohen authored and Greg Kroah-Hartman committed Jun 7, 2020
1 parent aea1423 commit 2528015
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ test_uc_aware()
local i

for ((i = 0; i < attempts; ++i)); do
if $ARPING -c 1 -I $h1 -b 192.0.2.66 -q -w 0.1; then
if $ARPING -c 1 -I $h1 -b 192.0.2.66 -q -w 1; then
((passes++))
fi

Expand Down

0 comments on commit 2528015

Please sign in to comment.