Skip to content

Commit

Permalink
xfs: remove nr_to_write writeback windup.
Browse files Browse the repository at this point in the history
Now that the background flush code has been fixed, we shouldn't need to
silently multiply the wbc->nr_to_write to get good writeback. Remove
that code.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Dave Chinner authored and Linus Torvalds committed Jun 9, 2010
1 parent 0b56492 commit 254c8c2
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions fs/xfs/linux-2.6/xfs_aops.c
Original file line number Diff line number Diff line change
Expand Up @@ -1381,14 +1381,6 @@ xfs_vm_writepage(
if (!page_has_buffers(page))
create_empty_buffers(page, 1 << inode->i_blkbits, 0);


/*
* VM calculation for nr_to_write seems off. Bump it way
* up, this gets simple streaming writes zippy again.
* To be reviewed again after Jens' writeback changes.
*/
wbc->nr_to_write *= 4;

/*
* Convert delayed allocate, unwritten or unmapped space
* to real space and flush out to disk.
Expand Down

0 comments on commit 254c8c2

Please sign in to comment.