Skip to content

Commit

Permalink
MMC: Poll card status after rescanning cards
Browse files Browse the repository at this point in the history
Some broken cards seem to process CMD1 even in stand-by state. The result is
that the card replies with ILLEGAL_COMMAND error for the next command sent
after rescanning. Currently the next command is select card, which would
return the error. But CMD7 does actually succeed and retries of the command
will timeout. The workaround is to poll card status after CMD1 to clear the
pending error.

Signed-off-by: Timo Teras <timo.teras@solidboot.com>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
  • Loading branch information
Timo Teras authored and Pierre Ossman committed Nov 9, 2006
1 parent 088406b commit 25a122f
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion drivers/mmc/mmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1178,14 +1178,29 @@ static void mmc_rescan(void *data)
{
struct mmc_host *host = data;
struct list_head *l, *n;
unsigned char power_mode;

mmc_claim_host(host);

if (host->ios.power_mode == MMC_POWER_ON)
/*
* Check for removed cards and newly inserted ones. We check for
* removed cards first so we can intelligently re-select the VDD.
*/
power_mode = host->ios.power_mode;
if (power_mode == MMC_POWER_ON)
mmc_check_cards(host);

mmc_setup(host);

/*
* Some broken cards process CMD1 even in stand-by state. There is
* no reply, but an ILLEGAL_COMMAND error is cached and returned
* after next command. We poll for card status here to clear any
* possibly pending error.
*/
if (power_mode == MMC_POWER_ON)
mmc_check_cards(host);

if (!list_empty(&host->cards)) {
/*
* (Re-)calculate the fastest clock rate which the
Expand Down

0 comments on commit 25a122f

Please sign in to comment.