Skip to content

Commit

Permalink
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel…
Browse files Browse the repository at this point in the history
…/git/dtor/input

Pull input fixes from Dmitry Torokhov:
 "Just a couple of fixups for Synaptics RMI4 driver and allowing
  snvs_pwrkey to be selected on more boards"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
  Input: synaptics-rmi4 - write config register values to the right offset
  Input: synaptics-rmi4 - fix possible double free
  Input: snvs_pwrkey - make it depend on ARCH_MXC
  • Loading branch information
Linus Torvalds committed Apr 27, 2019
2 parents 037904a + 3a34976 commit 25cce03
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion drivers/input/keyboard/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ config KEYBOARD_MPR121

config KEYBOARD_SNVS_PWRKEY
tristate "IMX SNVS Power Key Driver"
depends on SOC_IMX6SX || SOC_IMX7D
depends on ARCH_MXC || COMPILE_TEST
depends on OF
help
This is the snvs powerkey driver for the Freescale i.MX application
Expand Down
6 changes: 1 addition & 5 deletions drivers/input/rmi4/rmi_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ static int rmi_create_function(struct rmi_device *rmi_dev,

error = rmi_register_function(fn);
if (error)
goto err_put_fn;
return error;

if (pdt->function_number == 0x01)
data->f01_container = fn;
Expand All @@ -870,10 +870,6 @@ static int rmi_create_function(struct rmi_device *rmi_dev,
list_add_tail(&fn->node, &data->function_list);

return RMI_SCAN_CONTINUE;

err_put_fn:
put_device(&fn->dev);
return error;
}

void rmi_enable_irq(struct rmi_device *rmi_dev, bool clear_wake)
Expand Down
2 changes: 1 addition & 1 deletion drivers/input/rmi4/rmi_f11.c
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@ static int rmi_f11_initialize(struct rmi_function *fn)
}

rc = f11_write_control_regs(fn, &f11->sens_query,
&f11->dev_controls, fn->fd.query_base_addr);
&f11->dev_controls, fn->fd.control_base_addr);
if (rc)
dev_warn(&fn->dev, "Failed to write control registers\n");

Expand Down

0 comments on commit 25cce03

Please sign in to comment.