Skip to content

Commit

Permalink
perf maps: Set the kmaps for newly created/added kernel maps
Browse files Browse the repository at this point in the history
When using __maps__insert_sorted() the map kmaps field needs to be
initialized, as we need kernel maps to work with map__kmap().

Fix it by using the newly introduced map__set_kmap() method.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/lkml/Z74V0hZXrTLM6VIJ@x1
Link: https://lore.kernel.org/r/20250228211734.33781-3-acme@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
  • Loading branch information
Arnaldo Carvalho de Melo authored and Namhyung Kim committed Mar 6, 2025
1 parent 99deaf5 commit 25d9c03
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/perf/util/maps.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,9 @@ static int __maps__insert_sorted(struct maps *maps, unsigned int first_after_ind
}
RC_CHK_ACCESS(maps)->nr_maps = nr_maps + to_add;
maps__set_maps_by_name_sorted(maps, false);
map__set_kmap_maps(new1, maps);
map__set_kmap_maps(new2, maps);

check_invariants(maps);
return 0;
}
Expand Down

0 comments on commit 25d9c03

Please sign in to comment.