Skip to content

Commit

Permalink
usb: gadget: amd5536udc: avoid NULL pointer dereference in udc_pci_pr…
Browse files Browse the repository at this point in the history
…obe()

dev->pdev is NULL before `dev->pdev = pdev'; use pdev instead.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Xi Wang authored and Felipe Balbi committed Dec 13, 2012
1 parent deeeb9e commit 25e14c1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/gadget/amd5536udc.c
Original file line number Diff line number Diff line change
@@ -3231,7 +3231,7 @@ static int udc_pci_probe(
}

if (!pdev->irq) {
dev_err(&dev->pdev->dev, "irq not set\n");
dev_err(&pdev->dev, "irq not set\n");
kfree(dev);
dev = NULL;
retval = -ENODEV;
@@ -3250,7 +3250,7 @@ static int udc_pci_probe(
dev->txfifo = (u32 __iomem *)(dev->virt_addr + UDC_TXFIFO_ADDR);

if (request_irq(pdev->irq, udc_irq, IRQF_SHARED, name, dev) != 0) {
dev_dbg(&dev->pdev->dev, "request_irq(%d) fail\n", pdev->irq);
dev_dbg(&pdev->dev, "request_irq(%d) fail\n", pdev->irq);
kfree(dev);
dev = NULL;
retval = -EBUSY;

0 comments on commit 25e14c1

Please sign in to comment.