Skip to content

Commit

Permalink
dt-bindings: net: ave: Clean up clocks, resets, and their names using…
Browse files Browse the repository at this point in the history
… compatible string

Instead of "oneOf:" choices, use "allOf:" and "if:" to define clocks,
resets, and their names that can be taken by the compatible string.

The order of clock-names and reset-names doesn't change here.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kunihiko Hayashi authored and David S. Miller committed Apr 8, 2022
1 parent 73b193f commit 2610bd7
Showing 1 changed file with 38 additions and 17 deletions.
55 changes: 38 additions & 17 deletions Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ description: |
This describes the devicetree bindings for AVE ethernet controller
implemented on Socionext UniPhier SoCs.
allOf:
- $ref: ethernet-controller.yaml#

properties:
compatible:
enum:
Expand Down Expand Up @@ -44,25 +41,13 @@ properties:
minItems: 1
maxItems: 4

clock-names:
oneOf:
- items: # for Pro4
- const: gio
- const: ether
- const: ether-gb
- const: ether-phy
- const: ether # for others
clock-names: true

resets:
minItems: 1
maxItems: 2

reset-names:
oneOf:
- items: # for Pro4
- const: gio
- const: ether
- const: ether # for others
reset-names: true

socionext,syscon-phy-mode:
$ref: /schemas/types.yaml#/definitions/phandle-array
Expand All @@ -78,6 +63,42 @@ properties:
$ref: mdio.yaml#
unevaluatedProperties: false

allOf:
- $ref: ethernet-controller.yaml#
- if:
properties:
compatible:
contains:
const: socionext,uniphier-pro4-ave4
then:
properties:
clocks:
minItems: 4
maxItems: 4
clock-names:
items:
- const: gio
- const: ether
- const: ether-gb
- const: ether-phy
resets:
minItems: 2
maxItems: 2
reset-names:
items:
- const: gio
- const: ether
else:
properties:
clocks:
maxItems: 1
clock-names:
const: ether
resets:
maxItems: 1
reset-names:
const: ether

required:
- compatible
- reg
Expand Down

0 comments on commit 2610bd7

Please sign in to comment.