Skip to content

Commit

Permalink
netvsc: add comments about callback's and NAPI
Browse files Browse the repository at this point in the history
Add some short description of how callback's and NAPI interoperate.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
stephen hemminger authored and David S. Miller committed Mar 17, 2017
1 parent 6de38af commit 262b7f1
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion drivers/net/hyperv/netvsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1209,6 +1209,10 @@ static struct hv_device *netvsc_channel_to_device(struct vmbus_channel *channel)
return primary ? primary->device_obj : channel->device_obj;
}

/* Network processing softirq
* Process data in incoming ring buffer from host
* Stops when ring is empty or budget is met or exceeded.
*/
int netvsc_poll(struct napi_struct *napi, int budget)
{
struct netvsc_channel *nvchan
Expand Down Expand Up @@ -1238,7 +1242,11 @@ int netvsc_poll(struct napi_struct *napi, int budget)
}
hv_pkt_iter_close(channel);

/* If ring is empty and NAPI is not doing polling */
/* If budget was not exhausted and
* not doing busy poll
* then re-enable host interrupts
* and reschedule if ring is not empty.
*/
if (work_done < budget &&
napi_complete_done(napi, work_done) &&
hv_end_read(&channel->inbound) != 0)
Expand All @@ -1248,6 +1256,9 @@ int netvsc_poll(struct napi_struct *napi, int budget)
return work_done;
}

/* Call back when data is available in host ring buffer.
* Processing is deferred until network softirq (NAPI)
*/
void netvsc_channel_cb(void *context)
{
struct netvsc_channel *nvchan = context;
Expand Down

0 comments on commit 262b7f1

Please sign in to comment.