Skip to content

Commit

Permalink
drm/i915: Remove '& 0xffff' from the mask given to WA_REG()
Browse files Browse the repository at this point in the history
We may be hidding bugs by doing that, so let remove it and have the
actual mask value shine through, for better or worse.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
  • Loading branch information
Damien Lespiau authored and Jani Nikula committed Dec 10, 2014
1 parent cf4b0de commit 2645934
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/i915/intel_ringbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,10 @@ static int wa_add(struct drm_i915_private *dev_priv,
}

#define WA_SET_BIT_MASKED(addr, mask) \
WA_REG(addr, (mask) & 0xffff, _MASKED_BIT_ENABLE(mask))
WA_REG(addr, (mask), _MASKED_BIT_ENABLE(mask))

#define WA_CLR_BIT_MASKED(addr, mask) \
WA_REG(addr, (mask) & 0xffff, _MASKED_BIT_DISABLE(mask))
WA_REG(addr, (mask), _MASKED_BIT_DISABLE(mask))

#define WA_SET_FIELD_MASKED(addr, mask, value) \
WA_REG(addr, mask, _MASKED_FIELD(mask, value))
Expand Down

0 comments on commit 2645934

Please sign in to comment.