Skip to content

Commit

Permalink
net/sched: Retire rsvp classifier
Browse files Browse the repository at this point in the history
The rsvp classifier has served us well for about a quarter of a century but has
has not been getting much maintenance attention due to lack of known users.

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  • Loading branch information
Jamal Hadi Salim authored and Paolo Abeni committed Feb 16, 2023
1 parent 8c710f7 commit 265b4da
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 1,059 deletions.
10 changes: 0 additions & 10 deletions include/net/tc_wrapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ TC_INDIRECT_FILTER_DECLARE(flow_classify);
TC_INDIRECT_FILTER_DECLARE(fw_classify);
TC_INDIRECT_FILTER_DECLARE(mall_classify);
TC_INDIRECT_FILTER_DECLARE(route4_classify);
TC_INDIRECT_FILTER_DECLARE(rsvp_classify);
TC_INDIRECT_FILTER_DECLARE(rsvp6_classify);
TC_INDIRECT_FILTER_DECLARE(u32_classify);

static inline int tc_classify(struct sk_buff *skb, const struct tcf_proto *tp,
Expand Down Expand Up @@ -198,14 +196,6 @@ static inline int tc_classify(struct sk_buff *skb, const struct tcf_proto *tp,
if (tp->classify == route4_classify)
return route4_classify(skb, tp, res);
#endif
#if IS_BUILTIN(CONFIG_NET_CLS_RSVP)
if (tp->classify == rsvp_classify)
return rsvp_classify(skb, tp, res);
#endif
#if IS_BUILTIN(CONFIG_NET_CLS_RSVP6)
if (tp->classify == rsvp6_classify)
return rsvp6_classify(skb, tp, res);
#endif

skip:
return tp->classify(skb, tp, res);
Expand Down
28 changes: 0 additions & 28 deletions net/sched/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -513,34 +513,6 @@ config CLS_U32_MARK
help
Say Y here to be able to use netfilter marks as u32 key.

config NET_CLS_RSVP
tristate "IPv4 Resource Reservation Protocol (RSVP)"
select NET_CLS
help
The Resource Reservation Protocol (RSVP) permits end systems to
request a minimum and maximum data flow rate for a connection; this
is important for real time data such as streaming sound or video.

Say Y here if you want to be able to classify outgoing packets based
on their RSVP requests.

To compile this code as a module, choose M here: the
module will be called cls_rsvp.

config NET_CLS_RSVP6
tristate "IPv6 Resource Reservation Protocol (RSVP6)"
select NET_CLS
help
The Resource Reservation Protocol (RSVP) permits end systems to
request a minimum and maximum data flow rate for a connection; this
is important for real time data such as streaming sound or video.

Say Y here if you want to be able to classify outgoing packets based
on their RSVP requests and you are using the IPv6 protocol.

To compile this code as a module, choose M here: the
module will be called cls_rsvp6.

config NET_CLS_FLOW
tristate "Flow classifier"
select NET_CLS
Expand Down
2 changes: 0 additions & 2 deletions net/sched/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ obj-$(CONFIG_NET_SCH_TAPRIO) += sch_taprio.o
obj-$(CONFIG_NET_CLS_U32) += cls_u32.o
obj-$(CONFIG_NET_CLS_ROUTE4) += cls_route.o
obj-$(CONFIG_NET_CLS_FW) += cls_fw.o
obj-$(CONFIG_NET_CLS_RSVP) += cls_rsvp.o
obj-$(CONFIG_NET_CLS_RSVP6) += cls_rsvp6.o
obj-$(CONFIG_NET_CLS_BASIC) += cls_basic.o
obj-$(CONFIG_NET_CLS_FLOW) += cls_flow.o
obj-$(CONFIG_NET_CLS_CGROUP) += cls_cgroup.o
Expand Down
26 changes: 0 additions & 26 deletions net/sched/cls_rsvp.c

This file was deleted.

Loading

0 comments on commit 265b4da

Please sign in to comment.