Skip to content

Commit

Permalink
staging/lustre/libcfs: fix illegal page access of tracefiled()
Browse files Browse the repository at this point in the history
After failure happens and put_pages_back() returns the pages,
tracefiled() should not go on itering on the page list.
Otherwise, some pages might be accessed illegally.

Signed-off-by: Li Xi <lixi@ddn.com>
Signed-off-by: Jian Yu <jian.yu@intel.com>
Reviewed-on: http://review.whamcloud.com/11454
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5126
Reviewed-by: Emoly Liu <emoly.liu@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Li Xi authored and Greg Kroah-Hartman committed Feb 7, 2015
1 parent 13534f8 commit 2661e6c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/staging/lustre/lustre/libcfs/tracefile.c
Original file line number Diff line number Diff line change
Expand Up @@ -1037,6 +1037,7 @@ static int tracefiled(void *arg)
tage->used, rc);
put_pages_back(&pc);
__LASSERT(list_empty(&pc.pc_pages));
break;
}
}
MMSPACE_CLOSE;
Expand Down

0 comments on commit 2661e6c

Please sign in to comment.