Skip to content

Commit

Permalink
mei: drop ready bits check after start
Browse files Browse the repository at this point in the history
The check that hardware and host ready bits are set after start
is redundant and may fail and disable driver if there is
back-to-back link reset issued right after start.
This happens during pxp mode transitions when firmware
undergo reset. Remove these checks to eliminate such failures.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220907215113.1596567-14-tomas.winkler@intel.com
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
  • Loading branch information
Alexander Usyskin authored and Joonas Lahtinen committed Sep 12, 2022
1 parent bc9abe0 commit 267cb87
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/misc/mei/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev)
goto err;
}

if (!mei_host_is_ready(dev)) {
dev_err(dev->dev, "host is not ready.\n");
goto err;
}

if (!mei_hw_is_ready(dev)) {
dev_err(dev->dev, "ME is not ready.\n");
goto err;
}

if (!mei_hbm_version_is_supported(dev)) {
dev_dbg(dev->dev, "MEI start failed.\n");
goto err;
Expand Down

0 comments on commit 267cb87

Please sign in to comment.