Skip to content

Commit

Permalink
scsi: target: drop xcopy DISK BLOCK LENGTH debug
Browse files Browse the repository at this point in the history
The DISK BLOCK LENGTH field is carried with XCOPY target descriptors on the
wire, but is currently unmarshalled during 0x02 segment descriptor
passing. The unmarshalled value is currently unused, so drop it.

Link: https://lore.kernel.org/r/20200327141954.955-3-ddiss@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
David Disseldorp authored and Martin K. Petersen committed Mar 29, 2020
1 parent 95b1b51 commit 267fc83
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions drivers/target/target_core_xcopy.c
Original file line number Diff line number Diff line change
Expand Up @@ -315,11 +315,6 @@ static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_op
xop->nolb, (unsigned long long)xop->src_lba,
(unsigned long long)xop->dst_lba);

if (dc != 0) {
xop->dbl = get_unaligned_be24(&desc[29]);

pr_debug("XCOPY seg desc 0x02: DC=1 w/ dbl: %u\n", xop->dbl);
}
return 0;
}

Expand Down
1 change: 0 additions & 1 deletion drivers/target/target_core_xcopy.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ struct xcopy_op {
unsigned short stdi;
unsigned short dtdi;
unsigned short nolb;
unsigned int dbl;

struct xcopy_pt_cmd *src_pt_cmd;
struct xcopy_pt_cmd *dst_pt_cmd;
Expand Down

0 comments on commit 267fc83

Please sign in to comment.