Skip to content

Commit

Permalink
hv_netvsc: Print value of invalid ID in netvsc_send_{completion,tx_co…
Browse files Browse the repository at this point in the history
…mplete}()

That being useful for debugging purposes.

Notice that the packet descriptor is in "private" guest memory, so
that Hyper-V can not tamper with it.

While at it, remove two unnecessary u64-casts.

Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Andrea Parri (Microsoft) authored and Jakub Kicinski committed Apr 8, 2022
1 parent 4daf5f1 commit 26894cd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/hyperv/netvsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -792,9 +792,9 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
int queue_sends;
u64 cmd_rqst;

cmd_rqst = channel->request_addr_callback(channel, (u64)desc->trans_id);
cmd_rqst = channel->request_addr_callback(channel, desc->trans_id);
if (cmd_rqst == VMBUS_RQST_ERROR) {
netdev_err(ndev, "Incorrect transaction id\n");
netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);
return;
}

Expand Down Expand Up @@ -854,9 +854,9 @@ static void netvsc_send_completion(struct net_device *ndev,
/* First check if this is a VMBUS completion without data payload */
if (!msglen) {
cmd_rqst = incoming_channel->request_addr_callback(incoming_channel,
(u64)desc->trans_id);
desc->trans_id);
if (cmd_rqst == VMBUS_RQST_ERROR) {
netdev_err(ndev, "Invalid transaction id\n");
netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);
return;
}

Expand Down

0 comments on commit 26894cd

Please sign in to comment.