Skip to content

Commit

Permalink
net: nlmon: Simplify nlmon_get_stats64
Browse files Browse the repository at this point in the history
Do not set rtnl_link_stats64 fields to zero, since they are zeroed
before ops->ndo_get_stats64 is called in core dev_get_stats() function.

Also, simplify the data collection by removing the temporary variable.

Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Breno Leitao authored and David S. Miller committed Mar 4, 2024
1 parent 4f41ce8 commit 26b5df9
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions drivers/net/nlmon.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,7 @@ static int nlmon_close(struct net_device *dev)
static void
nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
{
u64 packets, bytes;

dev_lstats_read(dev, &packets, &bytes);

stats->rx_packets = packets;
stats->tx_packets = 0;

stats->rx_bytes = bytes;
stats->tx_bytes = 0;
dev_lstats_read(dev, &stats->rx_packets, &stats->rx_bytes);
}

static u32 always_on(struct net_device *dev)
Expand Down

0 comments on commit 26b5df9

Please sign in to comment.