Skip to content

Commit

Permalink
gpu: ipu-v3: image-convert: calculate tile dimensions and offsets out…
Browse files Browse the repository at this point in the history
…side fill_image

This will allow to calculate seam positions after initializing the
ipu_image base structure but before calculating tile dimensions.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Steve Longerbeam <slongerbeam@gmail.com>
Tested-by: Steve Longerbeam <slongerbeam@gmail.com>
  • Loading branch information
Philipp Zabel committed Nov 5, 2018
1 parent 571dd82 commit 26ddd03
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions drivers/gpu/ipu-v3/ipu-image-convert.c
Original file line number Diff line number Diff line change
Expand Up @@ -1467,9 +1467,7 @@ static int fill_image(struct ipu_image_convert_ctx *ctx,
else
ic_image->stride = ic_image->base.pix.bytesperline;

calc_tile_dimensions(ctx, ic_image);

return calc_tile_offsets(ctx, ic_image);
return 0;
}

/* borrowed from drivers/media/v4l2-core/v4l2-common.c */
Expand Down Expand Up @@ -1673,14 +1671,24 @@ ipu_image_convert_prepare(struct ipu_soc *ipu, enum ipu_ic_task ic_task,
ctx->num_tiles = d_image->num_cols * d_image->num_rows;
ctx->rot_mode = rot_mode;

ret = fill_image(ctx, s_image, in, IMAGE_CONVERT_IN);
if (ret)
goto out_free;
ret = fill_image(ctx, d_image, out, IMAGE_CONVERT_OUT);
if (ret)
goto out_free;

ret = calc_image_resize_coefficients(ctx, in, out);
if (ret)
goto out_free;

ret = fill_image(ctx, s_image, in, IMAGE_CONVERT_IN);
calc_tile_dimensions(ctx, s_image);
ret = calc_tile_offsets(ctx, s_image);
if (ret)
goto out_free;
ret = fill_image(ctx, d_image, out, IMAGE_CONVERT_OUT);

calc_tile_dimensions(ctx, d_image);
ret = calc_tile_offsets(ctx, d_image);
if (ret)
goto out_free;

Expand Down

0 comments on commit 26ddd03

Please sign in to comment.