Skip to content

Commit

Permalink
dmaengine: sirf: fix a typo in moving running dma_desc to active queue
Browse files Browse the repository at this point in the history
list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued)
undefined, we either should change it to:
list_move_tail(schan->queued.next, &schan->active)
or
list_move_tail(&sdesc->node, &schan->active)

Signed-off-by: Barry Song <Baohua.Song@csr.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
  • Loading branch information
Barry Song authored and Vinod Koul committed Oct 24, 2012
1 parent 5997e08 commit 26fd122
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dma/sirf-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan)
sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,
node);
/* Move the first queued descriptor to active list */
list_move_tail(&schan->queued, &schan->active);
list_move_tail(&sdesc->node, &schan->active);

/* Start the DMA transfer */
writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +
Expand Down

0 comments on commit 26fd122

Please sign in to comment.