Skip to content

Commit

Permalink
can: c_can: add ethtool support
Browse files Browse the repository at this point in the history
With commit 132f2d4 ("can: c_can: add support to 64 message
objects") the number of message objects used for reception /
transmission depends on FIFO size.

The ethtools API support allows you to retrieve this info. Driver info
has been added too.

Link: https://lore.kernel.org/r/20210514165549.14365-2-dariobin@libero.it
Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Dario Binacchi authored and Marc Kleine-Budde committed May 27, 2021
1 parent c7b0f68 commit 2722ac9
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/net/can/c_can/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@
#

obj-$(CONFIG_CAN_C_CAN) += c_can.o

c_can-objs :=
c_can-objs += c_can_ethtool.o
c_can-objs += c_can_main.o

obj-$(CONFIG_CAN_C_CAN_PLATFORM) += c_can_platform.o
obj-$(CONFIG_CAN_C_CAN_PCI) += c_can_pci.o
2 changes: 2 additions & 0 deletions drivers/net/can/c_can/c_can.h
Original file line number Diff line number Diff line change
Expand Up @@ -218,4 +218,6 @@ int c_can_power_up(struct net_device *dev);
int c_can_power_down(struct net_device *dev);
#endif

void c_can_set_ethtool_ops(struct net_device *dev);

#endif /* C_CAN_H */
43 changes: 43 additions & 0 deletions drivers/net/can/c_can/c_can_ethtool.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright 2021, Dario Binacchi <dariobin@libero.it>
*/

#include <linux/ethtool.h>
#include <linux/kernel.h>
#include <linux/platform_device.h>
#include <linux/netdevice.h>
#include <linux/can/dev.h>

#include "c_can.h"

static void c_can_get_drvinfo(struct net_device *netdev,
struct ethtool_drvinfo *info)
{
struct c_can_priv *priv = netdev_priv(netdev);
struct platform_device *pdev = to_platform_device(priv->device);

strscpy(info->driver, "c_can", sizeof(info->driver));
strscpy(info->bus_info, pdev->name, sizeof(info->bus_info));
}

static void c_can_get_ringparam(struct net_device *netdev,
struct ethtool_ringparam *ring)
{
struct c_can_priv *priv = netdev_priv(netdev);

ring->rx_max_pending = priv->msg_obj_num;
ring->tx_max_pending = priv->msg_obj_num;
ring->rx_pending = priv->msg_obj_rx_num;
ring->tx_pending = priv->msg_obj_tx_num;
}

static const struct ethtool_ops c_can_ethtool_ops = {
.get_drvinfo = c_can_get_drvinfo,
.get_ringparam = c_can_get_ringparam,
};

void c_can_set_ethtool_ops(struct net_device *netdev)
{
netdev->ethtool_ops = &c_can_ethtool_ops;
}
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,7 @@ int register_c_can_dev(struct net_device *dev)

dev->flags |= IFF_ECHO; /* we support local echo */
dev->netdev_ops = &c_can_netdev_ops;
c_can_set_ethtool_ops(dev);

err = register_candev(dev);
if (!err)
Expand Down

0 comments on commit 2722ac9

Please sign in to comment.