Skip to content

Commit

Permalink
Merge tag 'drm-xe-next-fixes-2024-05-09-1' of https://gitlab.freedesk…
Browse files Browse the repository at this point in the history
…top.org/drm/xe/kernel into drm-next

Driver Changes:
- Use ordered WQ for G2H handler. (Matthew Brost)
- Use flexible-array rather than zero-sized (Lucas De Marchi)

Signed-off-by: Dave Airlie <airlied@redhat.com>

From: Thomas Hellstrom <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/Zjz7SzCvfA3vQRxu@fedora
  • Loading branch information
Dave Airlie committed May 10, 2024
2 parents 110ed47 + d69c3d4 commit 275654c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/xe/xe_guc_ads.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ struct __guc_ads_blob {
struct guc_engine_usage engine_usage;
struct guc_um_init_params um_init_params;
/* From here on, location is dynamic! Refer to above diagram. */
struct guc_mmio_reg regset[0];
struct guc_mmio_reg regset[];
} __packed;

#define ads_blob_read(ads_, field_) \
Expand Down
5 changes: 5 additions & 0 deletions drivers/gpu/drm/xe/xe_guc_ct.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ static void guc_ct_fini(struct drm_device *drm, void *arg)
{
struct xe_guc_ct *ct = arg;

destroy_workqueue(ct->g2h_wq);
xa_destroy(&ct->fence_lookup);
}

Expand All @@ -146,6 +147,10 @@ int xe_guc_ct_init(struct xe_guc_ct *ct)

xe_gt_assert(gt, !(guc_ct_size() % PAGE_SIZE));

ct->g2h_wq = alloc_ordered_workqueue("xe-g2h-wq", 0);
if (!ct->g2h_wq)
return -ENOMEM;

spin_lock_init(&ct->fast_lock);
xa_init(&ct->fence_lookup);
INIT_WORK(&ct->g2h_worker, g2h_worker_func);
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/xe/xe_guc_ct.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static inline void xe_guc_ct_irq_handler(struct xe_guc_ct *ct)
return;

wake_up_all(&ct->wq);
queue_work(system_unbound_wq, &ct->g2h_worker);
queue_work(ct->g2h_wq, &ct->g2h_worker);
xe_guc_ct_fast_path(ct);
}

Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/xe/xe_guc_ct_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ struct xe_guc_ct {
wait_queue_head_t wq;
/** @g2h_fence_wq: wait queue used for G2H fencing */
wait_queue_head_t g2h_fence_wq;
/** @g2h_wq: used to process G2H */
struct workqueue_struct *g2h_wq;
/** @msg: Message buffer */
u32 msg[GUC_CTB_MSG_MAX_LEN];
/** @fast_msg: Message buffer */
Expand Down

0 comments on commit 275654c

Please sign in to comment.