Skip to content

Commit

Permalink
crypto: ccree - shared irq lines are not a bug
Browse files Browse the repository at this point in the history
The ccree driver was logging an error if it got an interrupt but
HW indicated nothing to do as might happen if sharing an irq line.
Remove the error as this is normal and we already have a debug
print for the IRR register value.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Gilad Ben-Yossef authored and Herbert Xu committed Jan 25, 2019
1 parent c139c72 commit 27649c3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/crypto/ccree/cc_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ static irqreturn_t cc_isr(int irq, void *dev_id)
/* read the interrupt status */
irr = cc_ioread(drvdata, CC_REG(HOST_IRR));
dev_dbg(dev, "Got IRR=0x%08X\n", irr);
if (irr == 0) { /* Probably shared interrupt line */
dev_err(dev, "Got interrupt with empty IRR\n");

if (irr == 0) /* Probably shared interrupt line */
return IRQ_NONE;
}

imr = cc_ioread(drvdata, CC_REG(HOST_IMR));

/* clear interrupt - must be before processing events */
Expand Down

0 comments on commit 27649c3

Please sign in to comment.