Skip to content

Commit

Permalink
svcrdma: Rename tracepoints that record header decoding errors
Browse files Browse the repository at this point in the history
Clean up: Use a consistent naming convention so that these trace
points can be enabled quickly via a glob.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
  • Loading branch information
Chuck Lever committed May 18, 2020
1 parent f5046b8 commit 27ce629
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
5 changes: 3 additions & 2 deletions include/trace/events/rpcrdma.h
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,7 @@ TRACE_EVENT(svcrdma_decode_rqst,
show_rpcrdma_proc(__entry->proc), __entry->hdrlen)
);

TRACE_EVENT(svcrdma_decode_short,
TRACE_EVENT(svcrdma_decode_short_err,
TP_PROTO(
unsigned int hdrlen
),
Expand Down Expand Up @@ -1399,7 +1399,8 @@ DECLARE_EVENT_CLASS(svcrdma_badreq_event,
);

#define DEFINE_BADREQ_EVENT(name) \
DEFINE_EVENT(svcrdma_badreq_event, svcrdma_decode_##name,\
DEFINE_EVENT(svcrdma_badreq_event, \
svcrdma_decode_##name##_err, \
TP_PROTO( \
__be32 *p \
), \
Expand Down
10 changes: 5 additions & 5 deletions net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
Original file line number Diff line number Diff line change
Expand Up @@ -665,23 +665,23 @@ static int svc_rdma_xdr_decode_req(struct xdr_buf *rq_arg,
return hdr_len;

out_short:
trace_svcrdma_decode_short(rq_arg->len);
trace_svcrdma_decode_short_err(rq_arg->len);
return -EINVAL;

out_version:
trace_svcrdma_decode_badvers(rdma_argp);
trace_svcrdma_decode_badvers_err(rdma_argp);
return -EPROTONOSUPPORT;

out_drop:
trace_svcrdma_decode_drop(rdma_argp);
trace_svcrdma_decode_drop_err(rdma_argp);
return 0;

out_proc:
trace_svcrdma_decode_badproc(rdma_argp);
trace_svcrdma_decode_badproc_err(rdma_argp);
return -EINVAL;

out_inval:
trace_svcrdma_decode_parse(rdma_argp);
trace_svcrdma_decode_parse_err(rdma_argp);
return -EINVAL;
}

Expand Down

0 comments on commit 27ce629

Please sign in to comment.