Skip to content

Commit

Permalink
staging: rtl8188eu: don't block until cmdthread runs
Browse files Browse the repository at this point in the history
rtw_start_drv_threads starts a cmdthread that runs in a loop. It
reads a command from a queue and processes it. There's no need for
any synchronization when this thread is started.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210505202622.11087-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Martin Kaiser authored and Greg Kroah-Hartman committed May 10, 2021
1 parent 13d6888 commit 286d600
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion drivers/staging/rtl8188eu/core/rtw_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ int rtw_cmd_thread(void *context)
allow_signal(SIGTERM);

pcmdpriv->cmdthd_running = true;
complete(&pcmdpriv->terminate_cmdthread_comp);

RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_,
("start r871x %s !!!!\n", __func__));
Expand Down
3 changes: 0 additions & 3 deletions drivers/staging/rtl8188eu/os_dep/os_intfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,6 @@ static int rtw_start_drv_threads(struct adapter *padapter)
"RTW_CMD_THREAD");
if (IS_ERR(padapter->cmdThread))
err = PTR_ERR(padapter->cmdThread);
else
/* wait for cmd_thread to run */
wait_for_completion_interruptible(&padapter->cmdpriv.terminate_cmdthread_comp);

return err;
}
Expand Down

0 comments on commit 286d600

Please sign in to comment.