Skip to content

Commit

Permalink
PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_pow…
Browse files Browse the repository at this point in the history
…erup()

When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Link: https://lore.kernel.org/r/20210511122453.6052-1-thunder.leizhen@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
  • Loading branch information
Zhen Lei authored and Lorenzo Pieralisi committed Jun 3, 2021
1 parent 6efb943 commit 28bba1e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/pci/controller/pcie-mediatek.c
Original file line number Diff line number Diff line change
Expand Up @@ -991,10 +991,8 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie)
regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");
if (regs) {
pcie->base = devm_ioremap_resource(dev, regs);
if (IS_ERR(pcie->base)) {
dev_err(dev, "failed to map shared register\n");
if (IS_ERR(pcie->base))
return PTR_ERR(pcie->base);
}
}

pcie->free_ck = devm_clk_get(dev, "free_ck");
Expand Down

0 comments on commit 28bba1e

Please sign in to comment.