Skip to content

Commit

Permalink
drm/amd/display: Cursor flicker when entering PSRSU
Browse files Browse the repository at this point in the history
[Why]
The DAL driver may transmit the wrong cursor position to PSRSU
DMUB driver when there are multiple planes.

[How]
Currently the driver apply the HW cursor on the top plane. So we
should only transmit the cursor position on the top plane to
PSRSU DMUB driver.

Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>
Acked-by: Brian Chang <Brian.Chang@amd.com>
Signed-off-by: Robin Chen <po-tchen@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Robin Chen authored and Alex Deucher committed Aug 25, 2022
1 parent 99c957f commit 28c0427
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
Original file line number Diff line number Diff line change
Expand Up @@ -3340,6 +3340,9 @@ static bool dcn10_dmub_should_update_cursor_data(
if (pipe_ctx->plane_state->address.type == PLN_ADDR_TYPE_VIDEO_PROGRESSIVE)
return false;

if (dcn10_can_pipe_disable_cursor(pipe_ctx))
return false;

if (pipe_ctx->stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1)
return true;

Expand Down

0 comments on commit 28c0427

Please sign in to comment.