Skip to content

Commit

Permalink
perf annotate: Fix the signedness of failure returns
Browse files Browse the repository at this point in the history
Callers of symbol__annotate() expect a errno value or some other
extended error value range in symbol__strerror_disassemble() to
convert to a proper error string, fix it when propagating a failure to
find the arch specific annotation routines via arch__find(arch_name).

Reported-by: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Cc: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/n/tip-o0k6dw7cas0vvmjjvgsyvu1i@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Sep 30, 2019
1 parent a66fa06 commit 28f4417
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/util/annotate.c
Original file line number Diff line number Diff line change
Expand Up @@ -2075,7 +2075,7 @@ int symbol__annotate(struct symbol *sym, struct map *map,

args.arch = arch = arch__find(arch_name);
if (arch == NULL)
return -ENOTSUP;
return ENOTSUP;

if (parch)
*parch = arch;
Expand Down

0 comments on commit 28f4417

Please sign in to comment.