Skip to content

Commit

Permalink
spi: intel: Add check devm_kasprintf() returned value
Browse files Browse the repository at this point in the history
intel_spi_populate_chip() use devm_kasprintf() to set pdata->name.
This can return a NULL pointer on failure but this returned value
is not checked.

Fixes: e58db3b ("spi: intel: Add default partition and name to the second chip")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://patch.msgid.link/20240830074106.8744-1-hanchunchao@inspur.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Charles Han authored and Mark Brown committed Aug 30, 2024
1 parent 5f3eee1 commit 2920294
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/spi/spi-intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1390,6 +1390,9 @@ static int intel_spi_populate_chip(struct intel_spi *ispi)

pdata->name = devm_kasprintf(ispi->dev, GFP_KERNEL, "%s-chip1",
dev_name(ispi->dev));
if (!pdata->name)
return -ENOMEM;

pdata->nr_parts = 1;
parts = devm_kcalloc(ispi->dev, pdata->nr_parts, sizeof(*parts),
GFP_KERNEL);
Expand Down

0 comments on commit 2920294

Please sign in to comment.