Skip to content

Commit

Permalink
ACPI, APEI, EINJ, cleanup 0 vs NULL confusion
Browse files Browse the repository at this point in the history
This function is returning pointers.  Sparse complains here:
drivers/acpi/apei/einj.c:262:32: warning:
	Using plain integer as NULL pointer

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Dan Carpenter authored and Len Brown committed Jan 24, 2012
1 parent 4c40aed commit 29924b9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/acpi/apei/einj.c
Original file line number Diff line number Diff line change
Expand Up @@ -259,15 +259,15 @@ static void *einj_get_parameter_address(void)

v4param = ioremap(paddrv4, sizeof(*v4param));
if (!v4param)
return 0;
return NULL;
if (readq(&v4param->reserved1) || readq(&v4param->reserved2)) {
iounmap(v4param);
return 0;
return NULL;
}
return v4param;
}

return 0;
return NULL;
}

/* do sanity check to trigger table */
Expand Down

0 comments on commit 29924b9

Please sign in to comment.