Skip to content

Commit

Permalink
fbdev: mb862xx: Fix check of return value from irq_of_parse_and_map()
Browse files Browse the repository at this point in the history
NO_IRQ is used to check the return of irq_of_parse_and_map().
On some architecture NO_IRQ is 0, on other architectures it is -1.
irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
So use 0 instead of using NO_IRQ.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Christophe Leroy authored and Helge Deller committed Oct 8, 2022
1 parent 3b29f36 commit 29926f1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ static int of_platform_mb862xx_probe(struct platform_device *ofdev)
par->dev = dev;

par->irq = irq_of_parse_and_map(np, 0);
if (par->irq == NO_IRQ) {
if (!par->irq) {
dev_err(dev, "failed to map irq\n");
ret = -ENODEV;
goto fbrel;
Expand Down

0 comments on commit 29926f1

Please sign in to comment.