Skip to content

Commit

Permalink
PCI: pciehp: Remove useless pciehp_get_latch_status() calls
Browse files Browse the repository at this point in the history
Long ago, we updated a "switch_save" field based on the latch status.  But
switch_save was unused, and ed6cbcf ("[PATCH] pciehp: miscellaneous
cleanups") removed it.

We no longer use the latch status, so remove calls to
pciehp_get_latch_status().  No functional change intended.

Tested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
  • Loading branch information
Bjorn Helgaas committed Sep 14, 2016
1 parent 6e49b30 commit 29a654e
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions drivers/pci/hotplug/pciehp_ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,6 @@ static void interrupt_event_handler(struct work_struct *work)
int pciehp_enable_slot(struct slot *p_slot)
{
u8 getstatus = 0;
int rc;
struct controller *ctrl = p_slot->ctrl;

pciehp_get_adapter_status(p_slot, &getstatus);
Expand All @@ -415,13 +414,7 @@ int pciehp_enable_slot(struct slot *p_slot)
}
}

pciehp_get_latch_status(p_slot, &getstatus);

rc = board_added(p_slot);
if (rc)
pciehp_get_latch_status(p_slot, &getstatus);

return rc;
return board_added(p_slot);
}

/*
Expand Down

0 comments on commit 29a654e

Please sign in to comment.