Skip to content

Commit

Permalink
ehea: fix operation state report
Browse files Browse the repository at this point in the history
Currently the ehea driver is missing a call to netif_carrier_off()
before the interface bring-up; this is necessary in order to
initialize the __LINK_STATE_NOCARRIER bit in the net_device state
field. Otherwise, we observe state UNKNOWN on "ip address" command
output.

This patch adds a call to netif_carrier_off() on ehea's net device
open callback.

Reported-by: Xiong Zhou <zhou@redhat.com>
Reference-ID: IBM bz #137702, Red Hat bz #1089134
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Guilherme G. Piccoli authored and David S. Miller committed Nov 3, 2016
1 parent 1aa9d1a commit 29ab5a3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/ethernet/ibm/ehea/ehea_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2446,6 +2446,8 @@ static int ehea_open(struct net_device *dev)

netif_info(port, ifup, dev, "enabling port\n");

netif_carrier_off(dev);

ret = ehea_up(dev);
if (!ret) {
port_napi_enable(port);
Expand Down

0 comments on commit 29ab5a3

Please sign in to comment.