Skip to content

Commit

Permalink
ASoC: samsung: fix return value check in i2s_alloc_dai()
Browse files Browse the repository at this point in the history
In case of error, the function platform_device_alloc() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Wei Yongjun authored and Mark Brown committed Oct 25, 2013
1 parent de0022d commit 29ca9c7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/samsung/i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec)
dev_set_drvdata(&i2s->pdev->dev, i2s);
} else { /* Create a new platform_device for Secondary */
i2s->pdev = platform_device_alloc("samsung-i2s-sec", -1);
if (IS_ERR(i2s->pdev))
if (!i2s->pdev)
return NULL;

i2s->pdev->dev.parent = &pdev->dev;
Expand Down

0 comments on commit 29ca9c7

Please sign in to comment.