Skip to content

Commit

Permalink
net: qrtr: free memory on error path in radix_tree_insert()
Browse files Browse the repository at this point in the history
Function radix_tree_insert() returns errors if the node hasn't
been initialized and added to the tree.

"kfree(node)" and return value "NULL" of node_get() help
to avoid using unclear node in other calls.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Cc: <stable@vger.kernel.org> # 5.7
Fixes: 0c2204a ("net: qrtr: Migrate nameservice to kernel from userspace")
Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://lore.kernel.org/r/20230125134831.8090-1-n.petrova@fintech.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Natalia Petrova authored and Jakub Kicinski committed Jan 28, 2023
1 parent 14caefc commit 29de68c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion net/qrtr/ns.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ static struct qrtr_node *node_get(unsigned int node_id)

node->id = node_id;

radix_tree_insert(&nodes, node_id, node);
if (radix_tree_insert(&nodes, node_id, node)) {
kfree(node);
return NULL;
}

return node;
}
Expand Down

0 comments on commit 29de68c

Please sign in to comment.