Skip to content

Commit

Permalink
pinctrl: sunxi: introduce IRQ bank conversion function
Browse files Browse the repository at this point in the history
The Allwinner H6 SoC have its pin controllers with the first IRQ-capable
GPIO bank at IRQ bank 1 and the second bank at IRQ bank 5. Some
refactors in the sunxi pinctrl framework are needed.

This commit introduces a IRQ bank conversion function, which replaces
the "(bank_base + bank)" code in IRQ register access.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Icenowy Zheng authored and Linus Walleij committed Mar 27, 2018
1 parent 4b0d6c5 commit 29dfc6b
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions drivers/pinctrl/sunxi/pinctrl-sunxi.h
Original file line number Diff line number Diff line change
Expand Up @@ -263,14 +263,19 @@ static inline u32 sunxi_pull_offset(u16 pin)
return pin_num * PULL_PINS_BITS;
}

static inline u32 sunxi_irq_hw_bank_num(const struct sunxi_pinctrl_desc *desc, u8 bank)
{
return desc->irq_bank_base + bank;
}

static inline u32 sunxi_irq_cfg_reg(const struct sunxi_pinctrl_desc *desc,
u16 irq)
{
unsigned bank_base = desc->irq_bank_base;
u8 bank = irq / IRQ_PER_BANK;
u8 reg = (irq % IRQ_PER_BANK) / IRQ_CFG_IRQ_PER_REG * 0x04;

return IRQ_CFG_REG + (bank_base + bank) * IRQ_MEM_SIZE + reg;
return IRQ_CFG_REG +
sunxi_irq_hw_bank_num(desc, bank) * IRQ_MEM_SIZE + reg;
}

static inline u32 sunxi_irq_cfg_offset(u16 irq)
Expand All @@ -281,9 +286,7 @@ static inline u32 sunxi_irq_cfg_offset(u16 irq)

static inline u32 sunxi_irq_ctrl_reg_from_bank(const struct sunxi_pinctrl_desc *desc, u8 bank)
{
unsigned bank_base = desc->irq_bank_base;

return IRQ_CTRL_REG + (bank_base + bank) * IRQ_MEM_SIZE;
return IRQ_CTRL_REG + sunxi_irq_hw_bank_num(desc, bank) * IRQ_MEM_SIZE;
}

static inline u32 sunxi_irq_ctrl_reg(const struct sunxi_pinctrl_desc *desc,
Expand All @@ -302,16 +305,14 @@ static inline u32 sunxi_irq_ctrl_offset(u16 irq)

static inline u32 sunxi_irq_debounce_reg_from_bank(const struct sunxi_pinctrl_desc *desc, u8 bank)
{
unsigned bank_base = desc->irq_bank_base;

return IRQ_DEBOUNCE_REG + (bank_base + bank) * IRQ_MEM_SIZE;
return IRQ_DEBOUNCE_REG +
sunxi_irq_hw_bank_num(desc, bank) * IRQ_MEM_SIZE;
}

static inline u32 sunxi_irq_status_reg_from_bank(const struct sunxi_pinctrl_desc *desc, u8 bank)
{
unsigned bank_base = desc->irq_bank_base;

return IRQ_STATUS_REG + (bank_base + bank) * IRQ_MEM_SIZE;
return IRQ_STATUS_REG +
sunxi_irq_hw_bank_num(desc, bank) * IRQ_MEM_SIZE;
}

static inline u32 sunxi_irq_status_reg(const struct sunxi_pinctrl_desc *desc,
Expand Down

0 comments on commit 29dfc6b

Please sign in to comment.