Skip to content

Commit

Permalink
x86/entry: Split PUSH_AND_CLEAR_REGS into two submacros
Browse files Browse the repository at this point in the history
PUSH_AND_CLEAR_REGS, as the name implies, performs two functions:
pushing registers and clearing registers. They don't necessarily have
to be performed in immediate sequence, although all current users
do. Split it into two macros for the case where that isn't desired;
the FRED enabling patchset will eventually make use of this.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210510185316.3307264-6-hpa@zytor.com
  • Loading branch information
H. Peter Anvin (Intel) authored and Ingo Molnar committed May 12, 2021
1 parent 6de4ac1 commit 29e9758
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion arch/x86/entry/calling.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ For 32-bit we have the following conventions - kernel is built with
* for assembly code:
*/

.macro PUSH_AND_CLEAR_REGS rdx=%rdx rax=%rax save_ret=0
.macro PUSH_REGS rdx=%rdx rax=%rax save_ret=0
.if \save_ret
pushq %rsi /* pt_regs->si */
movq 8(%rsp), %rsi /* temporarily store the return address in %rsi */
Expand All @@ -90,7 +90,9 @@ For 32-bit we have the following conventions - kernel is built with
.if \save_ret
pushq %rsi /* return address on top of stack */
.endif
.endm

.macro CLEAR_REGS
/*
* Sanitize registers of values that a speculation attack might
* otherwise want to exploit. The lower registers are likely clobbered
Expand All @@ -112,6 +114,11 @@ For 32-bit we have the following conventions - kernel is built with

.endm

.macro PUSH_AND_CLEAR_REGS rdx=%rdx rax=%rax save_ret=0
PUSH_REGS rdx=\rdx, rax=\rax, save_ret=\save_ret
CLEAR_REGS
.endm

.macro POP_REGS pop_rdi=1 skip_r11rcx=0
popq %r15
popq %r14
Expand Down

0 comments on commit 29e9758

Please sign in to comment.