Skip to content

Commit

Permalink
panel: rocktech: no need to check return value of debugfs_create func…
Browse files Browse the repository at this point in the history
…tions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "Guido Günther" <agx@sigxcpu.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613115717.GB26335@kroah.com
  • Loading branch information
Greg Kroah-Hartman authored and Daniel Vetter committed Jun 13, 2019
1 parent 90e7349 commit 2a08f2b
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,20 +257,12 @@ static int allpixelson_set(void *data, u64 val)
DEFINE_SIMPLE_ATTRIBUTE(allpixelson_fops, NULL,
allpixelson_set, "%llu\n");

static int jh057n_debugfs_init(struct jh057n *ctx)
static void jh057n_debugfs_init(struct jh057n *ctx)
{
struct dentry *f;

ctx->debugfs = debugfs_create_dir(DRV_NAME, NULL);
if (!ctx->debugfs)
return -ENOMEM;

f = debugfs_create_file("allpixelson", 0600,
ctx->debugfs, ctx, &allpixelson_fops);
if (!f)
return -ENOMEM;

return 0;
debugfs_create_file("allpixelson", 0600, ctx->debugfs, ctx,
&allpixelson_fops);
}

static void jh057n_debugfs_remove(struct jh057n *ctx)
Expand Down

0 comments on commit 2a08f2b

Please sign in to comment.