Skip to content

Commit

Permalink
drm/vblank: Add FIXME comments about moving the vblank ts hooks
Browse files Browse the repository at this point in the history
This is going to be a bit too much, but good to have at least a small
note about where this should all head towards.

Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170509140329.24114-3-daniel.vetter@ffwll.ch
  • Loading branch information
Daniel Vetter committed May 10, 2017
1 parent 3fcdcb2 commit 2a39b88
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions include/drm/drm_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,11 @@ struct drm_driver {
* constant but unknown small number of scanlines wrt. real scanout
* position.
*
* FIXME:
*
* Since this is a helper to implement @get_vblank_timestamp, we should
* move it to &struct drm_crtc_helper_funcs, like all the other
* helper-internal hooks.
*/
int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe,
unsigned int flags, int *vpos, int *hpos,
Expand Down Expand Up @@ -319,6 +324,11 @@ struct drm_driver {
*
* True on success, false on failure, which means the core should
* fallback to a simple timestamp taken in drm_crtc_handle_vblank().
*
* FIXME:
*
* We should move this hook to &struct drm_crtc_funcs like all the other
* vblank hooks.
*/
bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe,
int *max_error,
Expand Down

0 comments on commit 2a39b88

Please sign in to comment.