Skip to content

Commit

Permalink
pch_uart: change type to u8
Browse files Browse the repository at this point in the history
Target uart register access size is 8bit.
However, 32bit is used at 2 points.

This patch modifies type "unsigned int" to "unsigned char".

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Tomoya MORINAGA authored and Greg Kroah-Hartman committed Apr 9, 2012
1 parent 44db113 commit 2a58364
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/tty/serial/pch_uart.c
Original file line number Diff line number Diff line change
Expand Up @@ -552,14 +552,10 @@ static int pch_uart_hal_read(struct eg20t_port *priv, unsigned char *buf,
return i;
}

static unsigned int pch_uart_hal_get_iid(struct eg20t_port *priv)
static unsigned char pch_uart_hal_get_iid(struct eg20t_port *priv)
{
unsigned int iir;
int ret;

iir = ioread8(priv->membase + UART_IIR);
ret = (iir & (PCH_UART_IIR_IID | PCH_UART_IIR_TOI | PCH_UART_IIR_IP));
return ret;
return ioread8(priv->membase + UART_IIR) &\
(PCH_UART_IIR_IID | PCH_UART_IIR_TOI | PCH_UART_IIR_IP);
}

static u8 pch_uart_hal_get_line_status(struct eg20t_port *priv)
Expand Down Expand Up @@ -1045,7 +1041,7 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id)
unsigned int handled;
u8 lsr;
int ret = 0;
unsigned int iid;
unsigned char iid;
unsigned long flags;

spin_lock_irqsave(&priv->port.lock, flags);
Expand Down

0 comments on commit 2a58364

Please sign in to comment.