Skip to content

Commit

Permalink
Revert "x86/retpoline/crypto: Convert crypto assembler indirect jumps"
Browse files Browse the repository at this point in the history
This reverts commit 0153127f56d685b355e5adb5747f1d4463761756.

Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
  • Loading branch information
Sasha Levin committed Mar 21, 2018
1 parent 509efc5 commit 2ae2efd
Showing 4 changed files with 5 additions and 9 deletions.
5 changes: 2 additions & 3 deletions arch/x86/crypto/aesni-intel_asm.S
Original file line number Diff line number Diff line change
@@ -31,7 +31,6 @@

#include <linux/linkage.h>
#include <asm/inst.h>
#include <asm/nospec-branch.h>

/*
* The following macros are used to move an (un)aligned 16 byte value to/from
@@ -2715,7 +2714,7 @@ ENTRY(aesni_xts_crypt8)
pxor INC, STATE4
movdqu IV, 0x30(OUTP)

CALL_NOSPEC %r11
call *%r11

movdqu 0x00(OUTP), INC
pxor INC, STATE1
@@ -2760,7 +2759,7 @@ ENTRY(aesni_xts_crypt8)
_aesni_gf128mul_x_ble()
movups IV, (IVP)

CALL_NOSPEC %r11
call *%r11

movdqu 0x40(OUTP), INC
pxor INC, STATE1
3 changes: 1 addition & 2 deletions arch/x86/crypto/camellia-aesni-avx-asm_64.S
Original file line number Diff line number Diff line change
@@ -16,7 +16,6 @@
*/

#include <linux/linkage.h>
#include <asm/nospec-branch.h>

#define CAMELLIA_TABLE_BYTE_LEN 272

@@ -1211,7 +1210,7 @@ camellia_xts_crypt_16way:
vpxor 14 * 16(%rax), %xmm15, %xmm14;
vpxor 15 * 16(%rax), %xmm15, %xmm15;

CALL_NOSPEC %r9;
call *%r9;

addq $(16 * 16), %rsp;

3 changes: 1 addition & 2 deletions arch/x86/crypto/camellia-aesni-avx2-asm_64.S
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@
*/

#include <linux/linkage.h>
#include <asm/nospec-branch.h>

#define CAMELLIA_TABLE_BYTE_LEN 272

@@ -1324,7 +1323,7 @@ camellia_xts_crypt_32way:
vpxor 14 * 32(%rax), %ymm15, %ymm14;
vpxor 15 * 32(%rax), %ymm15, %ymm15;

CALL_NOSPEC %r9;
call *%r9;

addq $(16 * 32), %rsp;

3 changes: 1 addition & 2 deletions arch/x86/crypto/crc32c-pcl-intel-asm_64.S
Original file line number Diff line number Diff line change
@@ -45,7 +45,6 @@

#include <asm/inst.h>
#include <linux/linkage.h>
#include <asm/nospec-branch.h>

## ISCSI CRC 32 Implementation with crc32 and pclmulqdq Instruction

@@ -173,7 +172,7 @@ continue_block:
movzxw (bufp, %rax, 2), len
offset=crc_array-jump_table
lea offset(bufp, len, 1), bufp
JMP_NOSPEC bufp
jmp *bufp

################################################################
## 2a) PROCESS FULL BLOCKS:

0 comments on commit 2ae2efd

Please sign in to comment.