Skip to content

Commit

Permalink
s390/pci: free resources after failed bus allocation
Browse files Browse the repository at this point in the history
Free bus resources when the allocation/registration of the bus failed.

Reviewed-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Sebastian Ott authored and Martin Schwidefsky committed Jul 29, 2015
1 parent 6477682 commit 2b1df72
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions arch/s390/pci/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ static void zpci_cleanup_bus_resources(struct zpci_dev *zdev)
int i;

for (i = 0; i < PCI_BAR_COUNT; i++) {
if (!zdev->bars[i].size)
if (!zdev->bars[i].size || !zdev->bars[i].res)
continue;

zpci_free_iomap(zdev, zdev->bars[i].map_idx);
Expand Down Expand Up @@ -772,17 +772,22 @@ static int zpci_scan_bus(struct zpci_dev *zdev)

ret = zpci_setup_bus_resources(zdev, &resources);
if (ret)
return ret;
goto error;

zdev->bus = pci_scan_root_bus(NULL, ZPCI_BUS_NR, &pci_root_ops,
zdev, &resources);
if (!zdev->bus) {
zpci_cleanup_bus_resources(zdev);
return -EIO;
ret = -EIO;
goto error;
}
zdev->bus->max_bus_speed = zdev->max_bus_speed;
pci_bus_add_devices(zdev->bus);
return 0;

error:
zpci_cleanup_bus_resources(zdev);
pci_free_resource_list(&resources);
return ret;
}

int zpci_enable_device(struct zpci_dev *zdev)
Expand Down

0 comments on commit 2b1df72

Please sign in to comment.