Skip to content

Commit

Permalink
net: hns3: fix for getting advertised_caps in hns3_get_link_ksettings
Browse files Browse the repository at this point in the history
This patch fixes a bug for ethtool's get_link_ksettings().
The advertising for autoneg is always added to advertised_caps
whether autoneg is enable or disable. This patch fixes it.

Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Fuyun Liang authored and David S. Miller committed Nov 3, 2017
1 parent 16b5e50 commit 2b39cab
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,9 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
break;
}

if (!cmd->base.autoneg)
advertised_caps &= ~HNS3_LM_AUTONEG_BIT;

/* now, map driver link modes to ethtool link modes */
hns3_driv_to_eth_caps(supported_caps, cmd, false);
hns3_driv_to_eth_caps(advertised_caps, cmd, true);
Expand Down

0 comments on commit 2b39cab

Please sign in to comment.