Skip to content

Commit

Permalink
net/mlx5e: Fix error return code in mlx5e_tc_esw_init()
Browse files Browse the repository at this point in the history
Fix to return negative error code from the mlx5e_tc_tun_init() error
handling case instead of 0, as done elsewhere in this function.

This commit also using 0 instead of 'ret' when success since it is
always equal to 0.

Fixes: 8914add ("net/mlx5e: Handle FIB events to update tunnel endpoint device")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
  • Loading branch information
Wei Yongjun authored and Saeed Mahameed committed Feb 11, 2021
1 parent 4782c5d commit 2b6c3c1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -4750,10 +4750,12 @@ int mlx5e_tc_esw_init(struct rhashtable *tc_ht)
lockdep_set_class(&tc_ht->mutex, &tc_ht_lock_key);

uplink_priv->encap = mlx5e_tc_tun_init(priv);
if (IS_ERR(uplink_priv->encap))
if (IS_ERR(uplink_priv->encap)) {
err = PTR_ERR(uplink_priv->encap);
goto err_register_fib_notifier;
}

return err;
return 0;

err_register_fib_notifier:
rhashtable_destroy(tc_ht);
Expand Down

0 comments on commit 2b6c3c1

Please sign in to comment.