Skip to content

Commit

Permalink
libata: Remove FIXME comment in atapi_request_sense()
Browse files Browse the repository at this point in the history
Remove the FIXME comment in atapi_request_sense() asking whether
memset of sense buffer is necessary.  The buffer may be partially or
fully filled by the device.  We want it to be cleared.

tj: Updated description.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Nicholas Krause authored and Tejun Heo committed Dec 4, 2014
1 parent 598e9a9 commit 2ba520f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/ata/libata-scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -2595,7 +2595,6 @@ static void atapi_request_sense(struct ata_queued_cmd *qc)

DPRINTK("ATAPI request sense\n");

/* FIXME: is this needed? */
memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);

#ifdef CONFIG_ATA_SFF
Expand Down

0 comments on commit 2ba520f

Please sign in to comment.