Skip to content

Commit

Permalink
kernel/fail_function: fix memory leak with using debugfs_lookup()
Browse files Browse the repository at this point in the history
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230202151633.2310897-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Feb 8, 2023
1 parent a0bc3f7 commit 2bb3669
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions kernel/fail_function.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,7 @@ static void fei_debugfs_add_attr(struct fei_attr *attr)

static void fei_debugfs_remove_attr(struct fei_attr *attr)
{
struct dentry *dir;

dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);
debugfs_remove_recursive(dir);
debugfs_lookup_and_remove(attr->kp.symbol_name, fei_debugfs_dir);
}

static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)
Expand Down

0 comments on commit 2bb3669

Please sign in to comment.