Skip to content

Commit

Permalink
net: amd: pcnet32: Replace GFP_ATOMIC with GFP_KERNEL in pcnet32_allo…
Browse files Browse the repository at this point in the history
…c_ring()

pcnet32_alloc_ring() is never called in atomic context.
It calls kcalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jia-Ju Bai authored and David S. Miller committed Jul 27, 2018
1 parent 2db6dc2 commit 2bcd619
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/ethernet/amd/pcnet32.c
Original file line number Diff line number Diff line change
Expand Up @@ -2036,22 +2036,22 @@ static int pcnet32_alloc_ring(struct net_device *dev, const char *name)
}

lp->tx_dma_addr = kcalloc(lp->tx_ring_size, sizeof(dma_addr_t),
GFP_ATOMIC);
GFP_KERNEL);
if (!lp->tx_dma_addr)
return -ENOMEM;

lp->rx_dma_addr = kcalloc(lp->rx_ring_size, sizeof(dma_addr_t),
GFP_ATOMIC);
GFP_KERNEL);
if (!lp->rx_dma_addr)
return -ENOMEM;

lp->tx_skbuff = kcalloc(lp->tx_ring_size, sizeof(struct sk_buff *),
GFP_ATOMIC);
GFP_KERNEL);
if (!lp->tx_skbuff)
return -ENOMEM;

lp->rx_skbuff = kcalloc(lp->rx_ring_size, sizeof(struct sk_buff *),
GFP_ATOMIC);
GFP_KERNEL);
if (!lp->rx_skbuff)
return -ENOMEM;

Expand Down

0 comments on commit 2bcd619

Please sign in to comment.