neigh: check error pointer instead of NULL for ipv4_neigh_lookup()

Fixes: commit f187bc6 ("ipv4: No need to set generic neighbour pointer") Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
mariux64 · Sep 28, 2014 · 2c1a431 · 2c1a431
1 parent 86fa9c4
commit 2c1a431
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
@@ -746,7 +746,7 @@ static void __ip_do_redirect(struct rtable *rt, struct sk_buff *skb, struct flow
 	}
 
 	n = ipv4_neigh_lookup(&rt->dst, NULL, &new_gw);
-	if (n) {
+	if (!IS_ERR(n)) {
 		if (!(n->nud_state & NUD_VALID)) {
 			neigh_event_send(n, NULL);
 		} else {