Skip to content

Commit

Permalink
i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt
Browse files Browse the repository at this point in the history
The errata handling function acks wrong interrupt in case of "Arbitration
lost". Fix it.

Discovered during code review, the real impact of the bug is unknown.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
  • Loading branch information
Aaro Koskinen authored and Wolfram Sang committed Jan 22, 2013
1 parent 43a2bd4 commit 2c5de55
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-omap.c
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *dev)
if (stat & OMAP_I2C_STAT_AL) {
dev_err(dev->dev, "Arbitration lost\n");
dev->cmd_err |= OMAP_I2C_STAT_AL;
omap_i2c_ack_stat(dev, OMAP_I2C_STAT_NACK);
omap_i2c_ack_stat(dev, OMAP_I2C_STAT_AL);
}

return -EIO;
Expand Down

0 comments on commit 2c5de55

Please sign in to comment.