Skip to content

Commit

Permalink
dt-bindings: HID: i2c-hid: Add "panel" property to i2c-hid backed tou…
Browse files Browse the repository at this point in the history
…chscreens

As talked about in the patch ("drm/panel: Add a way for other devices
to follow panel state"), touchscreens that are connected to panels are
generally expected to be power sequenced together with the panel
they're attached to. Today, nothing provides information allowing you
to find out that a touchscreen is connected to a panel. Let's add a
phandle for this.

The proerty is added to the generic touchscreen bindings and then
enabled in the bindings for the i2c-hid backed devices. This can and
should be added for other touchscreens in the future, but for now
let's start small.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Benjamin Tissoires <bentiss@kernel.org>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230727101636.v4.1.Id68e30343bb1e11470582a9078b086176cfec46b@changeid
  • Loading branch information
Douglas Anderson committed Aug 1, 2023
1 parent 8229399 commit 2ca376e
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Documentation/devicetree/bindings/input/elan,ekth6915.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ description:
Supports the Elan eKTH6915 touchscreen controller.
This touchscreen controller uses the i2c-hid protocol with a reset GPIO.

allOf:
- $ref: /schemas/input/touchscreen/touchscreen.yaml#

properties:
compatible:
items:
Expand All @@ -24,6 +27,8 @@ properties:
interrupts:
maxItems: 1

panel: true

reset-gpios:
description: Reset GPIO; not all touchscreens using eKTH6915 hook this up.

Expand Down
5 changes: 5 additions & 0 deletions Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ description:
This touchscreen uses the i2c-hid protocol but has some non-standard
power sequencing required.

allOf:
- $ref: /schemas/input/touchscreen/touchscreen.yaml#

properties:
compatible:
oneOf:
Expand All @@ -30,6 +33,8 @@ properties:
interrupts:
maxItems: 1

panel: true

reset-gpios:
true

Expand Down
2 changes: 2 additions & 0 deletions Documentation/devicetree/bindings/input/hid-over-i2c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ properties:
description: HID descriptor address
$ref: /schemas/types.yaml#/definitions/uint32

panel: true

post-power-on-delay-ms:
description: Time required by the device after enabling its regulators
or powering it on, before it is ready for communication.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ maintainers:
- Dmitry Torokhov <dmitry.torokhov@gmail.com>

properties:
panel:
description: If this touchscreen is integrally connected to a panel, this
is a reference to that panel. The presence of this reference indicates
that the touchscreen should be power sequenced together with the panel
and that they may share power and/or reset signals.
$ref: /schemas/types.yaml#/definitions/phandle

touchscreen-min-x:
description: minimum x coordinate reported
$ref: /schemas/types.yaml#/definitions/uint32
Expand Down

0 comments on commit 2ca376e

Please sign in to comment.