Skip to content

Commit

Permalink
Merge tag 'char-misc-6.14-rc6' of git://git.kernel.org/pub/scm/linux/…
Browse files Browse the repository at this point in the history
…kernel/git/gregkh/char-misc

Pull char/misc/IIO driver fixes from Greg KH:
 "Here are a number of misc and char and iio driver fixes that have been
  sitting in my tree for way too long. They contain:

   - iio driver fixes for reported issues

   - regression fix for rtsx_usb card reader

   - mei and mhi driver fixes

   - small virt driver fixes

   - ntsync permissions fix

   - other tiny driver fixes for reported problems.

  All of these have been in linux-next for quite a while with no
  reported issues"

* tag 'char-misc-6.14-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (30 commits)
  Revert "drivers/card_reader/rtsx_usb: Restore interrupt based detection"
  ntsync: Check wait count based on byte size.
  bus: simple-pm-bus: fix forced runtime PM use
  char: misc: deallocate static minor in error path
  eeprom: digsy_mtc: Make GPIO lookup table match the device
  drivers: virt: acrn: hsm: Use kzalloc to avoid info leak in pmcmd_ioctl
  binderfs: fix use-after-free in binder_devices
  slimbus: messaging: Free transaction ID in delayed interrupt scenario
  vbox: add HAS_IOPORT dependency
  cdx: Fix possible UAF error in driver_override_show()
  intel_th: pci: Add Panther Lake-P/U support
  intel_th: pci: Add Panther Lake-H support
  intel_th: pci: Add Arrow Lake support
  intel_th: msu: Fix less trivial kernel-doc warnings
  intel_th: msu: Fix kernel-doc warnings
  MAINTAINERS: change maintainer for FSI
  ntsync: Set the permissions to be 0666
  bus: mhi: host: pci_generic: Use pci_try_reset_function() to avoid deadlock
  mei: vsc: Use "wakeuphostint" when getting the host wakeup GPIO
  mei: me: add panther lake P DID
  ...
  • Loading branch information
Linus Torvalds committed Mar 9, 2025
2 parents a382b06 + 2397d61 commit 2cc699b
Show file tree
Hide file tree
Showing 27 changed files with 139 additions and 85 deletions.
1 change: 1 addition & 0 deletions Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ properties:
maxItems: 2

pwm-names:
minItems: 1
items:
- const: convst1
- const: convst2
Expand Down
7 changes: 2 additions & 5 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -9443,14 +9443,11 @@ F: include/linux/fscrypt.h
F: include/uapi/linux/fscrypt.h

FSI SUBSYSTEM
M: Jeremy Kerr <jk@ozlabs.org>
M: Joel Stanley <joel@jms.id.au>
R: Alistar Popple <alistair@popple.id.au>
R: Eddie James <eajames@linux.ibm.com>
M: Eddie James <eajames@linux.ibm.com>
R: Ninad Palsule <ninad@linux.ibm.com>
L: linux-fsi@lists.ozlabs.org
S: Supported
Q: http://patchwork.ozlabs.org/project/linux-fsi/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/fsi.git
F: drivers/fsi/
F: include/linux/fsi*.h
F: include/trace/events/fsi*.h
Expand Down
1 change: 1 addition & 0 deletions drivers/android/binderfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ static void binderfs_evict_inode(struct inode *inode)
mutex_unlock(&binderfs_minors_mutex);

if (refcount_dec_and_test(&device->ref)) {
hlist_del_init(&device->hlist);
kfree(device->context.name);
kfree(device);
}
Expand Down
5 changes: 3 additions & 2 deletions drivers/bus/mhi/host/pci_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1095,8 +1095,9 @@ static void mhi_pci_recovery_work(struct work_struct *work)
err_unprepare:
mhi_unprepare_after_power_down(mhi_cntrl);
err_try_reset:
if (pci_reset_function(pdev))
dev_err(&pdev->dev, "Recovery failed\n");
err = pci_try_reset_function(pdev);
if (err)
dev_err(&pdev->dev, "Recovery failed: %d\n", err);
}

static void health_check(struct timer_list *t)
Expand Down
22 changes: 21 additions & 1 deletion drivers/bus/simple-pm-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,29 @@ static int simple_pm_bus_runtime_resume(struct device *dev)
return 0;
}

static int simple_pm_bus_suspend(struct device *dev)
{
struct simple_pm_bus *bus = dev_get_drvdata(dev);

if (!bus)
return 0;

return pm_runtime_force_suspend(dev);
}

static int simple_pm_bus_resume(struct device *dev)
{
struct simple_pm_bus *bus = dev_get_drvdata(dev);

if (!bus)
return 0;

return pm_runtime_force_resume(dev);
}

static const struct dev_pm_ops simple_pm_bus_pm_ops = {
RUNTIME_PM_OPS(simple_pm_bus_runtime_suspend, simple_pm_bus_runtime_resume, NULL)
NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
NOIRQ_SYSTEM_SLEEP_PM_OPS(simple_pm_bus_suspend, simple_pm_bus_resume)
};

#define ONLY_BUS ((void *) 1) /* Match if the device is only a bus. */
Expand Down
6 changes: 5 additions & 1 deletion drivers/cdx/cdx.c
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,12 @@ static ssize_t driver_override_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct cdx_device *cdx_dev = to_cdx_device(dev);
ssize_t len;

return sysfs_emit(buf, "%s\n", cdx_dev->driver_override);
device_lock(dev);
len = sysfs_emit(buf, "%s\n", cdx_dev->driver_override);
device_unlock(dev);
return len;
}
static DEVICE_ATTR_RW(driver_override);

Expand Down
2 changes: 1 addition & 1 deletion drivers/char/misc.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@ int misc_register(struct miscdevice *misc)
device_create_with_groups(&misc_class, misc->parent, dev,
misc, misc->groups, "%s", misc->name);
if (IS_ERR(misc->this_device)) {
misc_minor_free(misc->minor);
if (is_dynamic) {
misc_minor_free(misc->minor);
misc->minor = MISC_DYNAMIC_MINOR;
}
err = PTR_ERR(misc->this_device);
Expand Down
13 changes: 11 additions & 2 deletions drivers/hwtracing/intel_th/msu.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,23 +105,32 @@ struct msc_iter {

/**
* struct msc - MSC device representation
* @reg_base: register window base address
* @reg_base: register window base address for the entire MSU
* @msu_base: register window base address for this MSC
* @thdev: intel_th_device pointer
* @mbuf: MSU buffer, if assigned
* @mbuf_priv MSU buffer's private data, if @mbuf
* @mbuf_priv: MSU buffer's private data, if @mbuf
* @work: a work to stop the trace when the buffer is full
* @win_list: list of windows in multiblock mode
* @single_sgt: single mode buffer
* @cur_win: current window
* @switch_on_unlock: window to switch to when it becomes available
* @nr_pages: total number of pages allocated for this buffer
* @single_sz: amount of data in single mode
* @single_wrap: single mode wrap occurred
* @base: buffer's base pointer
* @base_addr: buffer's base address
* @orig_addr: MSC0 buffer's base address
* @orig_sz: MSC0 buffer's size
* @user_count: number of users of the buffer
* @mmap_count: number of mappings
* @buf_mutex: mutex to serialize access to buffer-related bits
* @iter_list: list of open file descriptor iterators
* @stop_on_full: stop the trace if the current window is full
* @enabled: MSC is enabled
* @wrap: wrapping is enabled
* @do_irq: IRQ resource is available, handle interrupts
* @multi_is_broken: multiblock mode enabled (not disabled by PCI drvdata)
* @mode: MSC operating mode
* @burst_len: write burst length
* @index: number of this MSC in the MSU
Expand Down
15 changes: 15 additions & 0 deletions drivers/hwtracing/intel_th/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,21 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xa824),
.driver_data = (kernel_ulong_t)&intel_th_2x,
},
{
/* Arrow Lake */
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x7724),
.driver_data = (kernel_ulong_t)&intel_th_2x,
},
{
/* Panther Lake-H */
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe324),
.driver_data = (kernel_ulong_t)&intel_th_2x,
},
{
/* Panther Lake-P/U */
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe424),
.driver_data = (kernel_ulong_t)&intel_th_2x,
},
{
/* Alder Lake CPU */
PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x466f),
Expand Down
2 changes: 1 addition & 1 deletion drivers/iio/adc/ad7192.c
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ static int ad7192_update_scan_mode(struct iio_dev *indio_dev, const unsigned lon

conf &= ~AD7192_CONF_CHAN_MASK;
for_each_set_bit(i, scan_mask, 8)
conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i);
conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i));

ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf);
if (ret < 0)
Expand Down
2 changes: 1 addition & 1 deletion drivers/iio/adc/ad7606.c
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ static int ad7606_read_avail(struct iio_dev *indio_dev,

cs = &st->chan_scales[ch];
*vals = (int *)cs->scale_avail;
*length = cs->num_scales;
*length = cs->num_scales * 2;
*type = IIO_VAL_INT_PLUS_MICRO;

return IIO_AVAIL_LIST;
Expand Down
68 changes: 40 additions & 28 deletions drivers/iio/adc/at91-sama5d2_adc.c
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,15 @@ static const struct at91_adc_reg_layout sama7g5_layout = {
#define AT91_HWFIFO_MAX_SIZE_STR "128"
#define AT91_HWFIFO_MAX_SIZE 128

#define AT91_SAMA5D2_CHAN_SINGLE(index, num, addr) \
#define AT91_SAMA_CHAN_SINGLE(index, num, addr, rbits) \
{ \
.type = IIO_VOLTAGE, \
.channel = num, \
.address = addr, \
.scan_index = index, \
.scan_type = { \
.sign = 'u', \
.realbits = 14, \
.realbits = rbits, \
.storagebits = 16, \
}, \
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
Expand All @@ -350,7 +350,13 @@ static const struct at91_adc_reg_layout sama7g5_layout = {
.indexed = 1, \
}

#define AT91_SAMA5D2_CHAN_DIFF(index, num, num2, addr) \
#define AT91_SAMA5D2_CHAN_SINGLE(index, num, addr) \
AT91_SAMA_CHAN_SINGLE(index, num, addr, 14)

#define AT91_SAMA7G5_CHAN_SINGLE(index, num, addr) \
AT91_SAMA_CHAN_SINGLE(index, num, addr, 16)

#define AT91_SAMA_CHAN_DIFF(index, num, num2, addr, rbits) \
{ \
.type = IIO_VOLTAGE, \
.differential = 1, \
Expand All @@ -360,7 +366,7 @@ static const struct at91_adc_reg_layout sama7g5_layout = {
.scan_index = index, \
.scan_type = { \
.sign = 's', \
.realbits = 14, \
.realbits = rbits, \
.storagebits = 16, \
}, \
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
Expand All @@ -373,6 +379,12 @@ static const struct at91_adc_reg_layout sama7g5_layout = {
.indexed = 1, \
}

#define AT91_SAMA5D2_CHAN_DIFF(index, num, num2, addr) \
AT91_SAMA_CHAN_DIFF(index, num, num2, addr, 14)

#define AT91_SAMA7G5_CHAN_DIFF(index, num, num2, addr) \
AT91_SAMA_CHAN_DIFF(index, num, num2, addr, 16)

#define AT91_SAMA5D2_CHAN_TOUCH(num, name, mod) \
{ \
.type = IIO_POSITIONRELATIVE, \
Expand Down Expand Up @@ -666,30 +678,30 @@ static const struct iio_chan_spec at91_sama5d2_adc_channels[] = {
};

static const struct iio_chan_spec at91_sama7g5_adc_channels[] = {
AT91_SAMA5D2_CHAN_SINGLE(0, 0, 0x60),
AT91_SAMA5D2_CHAN_SINGLE(1, 1, 0x64),
AT91_SAMA5D2_CHAN_SINGLE(2, 2, 0x68),
AT91_SAMA5D2_CHAN_SINGLE(3, 3, 0x6c),
AT91_SAMA5D2_CHAN_SINGLE(4, 4, 0x70),
AT91_SAMA5D2_CHAN_SINGLE(5, 5, 0x74),
AT91_SAMA5D2_CHAN_SINGLE(6, 6, 0x78),
AT91_SAMA5D2_CHAN_SINGLE(7, 7, 0x7c),
AT91_SAMA5D2_CHAN_SINGLE(8, 8, 0x80),
AT91_SAMA5D2_CHAN_SINGLE(9, 9, 0x84),
AT91_SAMA5D2_CHAN_SINGLE(10, 10, 0x88),
AT91_SAMA5D2_CHAN_SINGLE(11, 11, 0x8c),
AT91_SAMA5D2_CHAN_SINGLE(12, 12, 0x90),
AT91_SAMA5D2_CHAN_SINGLE(13, 13, 0x94),
AT91_SAMA5D2_CHAN_SINGLE(14, 14, 0x98),
AT91_SAMA5D2_CHAN_SINGLE(15, 15, 0x9c),
AT91_SAMA5D2_CHAN_DIFF(16, 0, 1, 0x60),
AT91_SAMA5D2_CHAN_DIFF(17, 2, 3, 0x68),
AT91_SAMA5D2_CHAN_DIFF(18, 4, 5, 0x70),
AT91_SAMA5D2_CHAN_DIFF(19, 6, 7, 0x78),
AT91_SAMA5D2_CHAN_DIFF(20, 8, 9, 0x80),
AT91_SAMA5D2_CHAN_DIFF(21, 10, 11, 0x88),
AT91_SAMA5D2_CHAN_DIFF(22, 12, 13, 0x90),
AT91_SAMA5D2_CHAN_DIFF(23, 14, 15, 0x98),
AT91_SAMA7G5_CHAN_SINGLE(0, 0, 0x60),
AT91_SAMA7G5_CHAN_SINGLE(1, 1, 0x64),
AT91_SAMA7G5_CHAN_SINGLE(2, 2, 0x68),
AT91_SAMA7G5_CHAN_SINGLE(3, 3, 0x6c),
AT91_SAMA7G5_CHAN_SINGLE(4, 4, 0x70),
AT91_SAMA7G5_CHAN_SINGLE(5, 5, 0x74),
AT91_SAMA7G5_CHAN_SINGLE(6, 6, 0x78),
AT91_SAMA7G5_CHAN_SINGLE(7, 7, 0x7c),
AT91_SAMA7G5_CHAN_SINGLE(8, 8, 0x80),
AT91_SAMA7G5_CHAN_SINGLE(9, 9, 0x84),
AT91_SAMA7G5_CHAN_SINGLE(10, 10, 0x88),
AT91_SAMA7G5_CHAN_SINGLE(11, 11, 0x8c),
AT91_SAMA7G5_CHAN_SINGLE(12, 12, 0x90),
AT91_SAMA7G5_CHAN_SINGLE(13, 13, 0x94),
AT91_SAMA7G5_CHAN_SINGLE(14, 14, 0x98),
AT91_SAMA7G5_CHAN_SINGLE(15, 15, 0x9c),
AT91_SAMA7G5_CHAN_DIFF(16, 0, 1, 0x60),
AT91_SAMA7G5_CHAN_DIFF(17, 2, 3, 0x68),
AT91_SAMA7G5_CHAN_DIFF(18, 4, 5, 0x70),
AT91_SAMA7G5_CHAN_DIFF(19, 6, 7, 0x78),
AT91_SAMA7G5_CHAN_DIFF(20, 8, 9, 0x80),
AT91_SAMA7G5_CHAN_DIFF(21, 10, 11, 0x88),
AT91_SAMA7G5_CHAN_DIFF(22, 12, 13, 0x90),
AT91_SAMA7G5_CHAN_DIFF(23, 14, 15, 0x98),
IIO_CHAN_SOFT_TIMESTAMP(24),
AT91_SAMA5D2_CHAN_TEMP(AT91_SAMA7G5_ADC_TEMP_CHANNEL, "temp", 0xdc),
};
Expand Down
2 changes: 1 addition & 1 deletion drivers/iio/adc/pac1921.c
Original file line number Diff line number Diff line change
Expand Up @@ -1198,11 +1198,11 @@ static int pac1921_match_acpi_device(struct iio_dev *indio_dev)

label = devm_kstrdup(dev, status->package.elements[0].string.pointer,
GFP_KERNEL);
ACPI_FREE(status);
if (!label)
return -ENOMEM;

indio_dev->label = label;
ACPI_FREE(status);

return 0;
}
Expand Down
6 changes: 6 additions & 0 deletions drivers/iio/dac/ad3552r.c
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,12 @@ static int ad3552r_reset(struct ad3552r_desc *dac)
return ret;
}

/* Clear reset error flag, see ad3552r manual, rev B table 38. */
ret = ad3552r_write_reg(dac, AD3552R_REG_ADDR_ERR_STATUS,
AD3552R_MASK_RESET_STATUS);
if (ret)
return ret;

return ad3552r_update_reg_field(dac,
AD3552R_REG_ADDR_INTERFACE_CONFIG_A,
AD3552R_MASK_ADDR_ASCENSION,
Expand Down
14 changes: 4 additions & 10 deletions drivers/iio/filter/admv8818.c
Original file line number Diff line number Diff line change
Expand Up @@ -574,21 +574,15 @@ static int admv8818_init(struct admv8818_state *st)
struct spi_device *spi = st->spi;
unsigned int chip_id;

ret = regmap_update_bits(st->regmap, ADMV8818_REG_SPI_CONFIG_A,
ADMV8818_SOFTRESET_N_MSK |
ADMV8818_SOFTRESET_MSK,
FIELD_PREP(ADMV8818_SOFTRESET_N_MSK, 1) |
FIELD_PREP(ADMV8818_SOFTRESET_MSK, 1));
ret = regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A,
ADMV8818_SOFTRESET_N_MSK | ADMV8818_SOFTRESET_MSK);
if (ret) {
dev_err(&spi->dev, "ADMV8818 Soft Reset failed.\n");
return ret;
}

ret = regmap_update_bits(st->regmap, ADMV8818_REG_SPI_CONFIG_A,
ADMV8818_SDOACTIVE_N_MSK |
ADMV8818_SDOACTIVE_MSK,
FIELD_PREP(ADMV8818_SDOACTIVE_N_MSK, 1) |
FIELD_PREP(ADMV8818_SDOACTIVE_MSK, 1));
ret = regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A,
ADMV8818_SDOACTIVE_N_MSK | ADMV8818_SDOACTIVE_MSK);
if (ret) {
dev_err(&spi->dev, "ADMV8818 SDO Enable failed.\n");
return ret;
Expand Down
4 changes: 2 additions & 2 deletions drivers/iio/light/apds9306.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ static const struct part_id_gts_multiplier apds9306_gts_mul[] = {
{
.part_id = 0xB1,
.max_scale_int = 16,
.max_scale_nano = 3264320,
.max_scale_nano = 326432000,
}, {
.part_id = 0xB3,
.max_scale_int = 14,
.max_scale_nano = 9712000,
.max_scale_nano = 97120000,
},
};

Expand Down
7 changes: 4 additions & 3 deletions drivers/iio/light/hid-sensor-prox.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ static const u32 prox_sensitivity_addresses[] = {
#define PROX_CHANNEL(_is_proximity, _channel) \
{\
.type = _is_proximity ? IIO_PROXIMITY : IIO_ATTENTION,\
.info_mask_separate = _is_proximity ? BIT(IIO_CHAN_INFO_RAW) :\
BIT(IIO_CHAN_INFO_PROCESSED),\
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |\
.info_mask_separate = \
(_is_proximity ? BIT(IIO_CHAN_INFO_RAW) :\
BIT(IIO_CHAN_INFO_PROCESSED)) |\
BIT(IIO_CHAN_INFO_OFFSET) |\
BIT(IIO_CHAN_INFO_SCALE) |\
BIT(IIO_CHAN_INFO_SAMP_FREQ) |\
BIT(IIO_CHAN_INFO_HYSTERESIS),\
Expand Down
3 changes: 2 additions & 1 deletion drivers/iio/proximity/hx9023s.c
Original file line number Diff line number Diff line change
Expand Up @@ -1036,12 +1036,13 @@ static int hx9023s_send_cfg(const struct firmware *fw, struct hx9023s_data *data
return -ENOMEM;

memcpy(bin->data, fw->data, fw->size);
release_firmware(fw);

bin->fw_size = fw->size;
bin->fw_ver = bin->data[FW_VER_OFFSET];
bin->reg_count = get_unaligned_le16(bin->data + FW_REG_CNT_OFFSET);

release_firmware(fw);

return hx9023s_bin_load(data, bin);
}

Expand Down
Loading

0 comments on commit 2cc699b

Please sign in to comment.